Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preliminary SC lint rules implementation and some testing #94

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichaelSt98
Copy link
Collaborator

Preliminary implementation of lint rules for SC ...

Draft PR for some feedback and to start a discussion ...


  • test/execute via LOKI_DEBUG=1 loki-lint.py --debug --rules-module sc check --basedir <...>/loki --include ....
    • "test_sc_1.F90"
    • "test_sc_2.F90"
    • ...

@MichaelSt98 MichaelSt98 requested review from mlange05 and reuterbal June 7, 2023 09:35
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/94/index.html

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Attention: Patch coverage is 0% with 192 lines in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (1d2025a) to head (8db6852).
Report is 1387 commits behind head on main.

Files with missing lines Patch % Lines
lint_rules/lint_rules/sc.py 0.00% 192 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   91.78%   90.90%   -0.88%     
==========================================
  Files          86       90       +4     
  Lines       15281    16388    +1107     
==========================================
+ Hits        14025    14898     +873     
- Misses       1256     1490     +234     
Flag Coverage Δ
lint_rules 56.55% <0.00%> (-40.82%) ⬇️
loki 92.04% <ø> (+0.02%) ⬆️
transformations 90.62% <ø> (+3.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant